Messages in this thread | | | Date | Mon, 17 Dec 2018 12:01:11 +0100 | From | Dominique Martinet <> | Subject | Re: [PATCH 1/3] 9p/net: implement asynchronous rpc |
| |
Tomas Bortoli wrote on Mon, Dec 17, 2018: > sorry for the delay, I've been quite busy these days.
No problem.
> The patches looks good to me and should indeed speed up the code a bit. > I quickly tested them against Syzkaller tuned for the 9p subsystem and > everything seems fine.
Thanks, can I add your Reviewed-by on all three?
> And by the way, which refcount races?
There's a problem with trans_fd read_work and cancelled callback; I'm not so sure about refcount but we can definitely get double list_del as we're not checking the status. I think when we incorrectly remove from the list we also mismanage the refcount, but honestly need to test..
-- Dominique
| |