Messages in this thread | | | Date | Thu, 13 Dec 2018 14:38:18 -0500 | From | Masayoshi Mizuma <> | Subject | Re: [PATCH v13 2/6] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC |
| |
On Thu, Dec 13, 2018 at 08:29:50PM +0100, Borislav Petkov wrote: > On Thu, Dec 13, 2018 at 02:25:30PM -0500, Masayoshi Mizuma wrote: > > > + len = cmdline_find_option("acpi_rsdp", val, MAX_ADDRESS_LENGTH+1); > > > > sizeof() is better here. > > > > len = cmdline_find_option("acpi_rsdp", val, sizeof(var)); > > Why is it better? > > That makes you go look for the "val" variable and see what it's size is. > MAX_ADDRESS_LENGTH+1 is OTOH explicit.
Ah, thanks, make sense.
- Masa
| |