Messages in this thread | | | From | Tianyu Lan <> | Date | Thu, 13 Dec 2018 15:47:31 +0800 | Subject | Re: [Resend PATCH V5 7/10] KVM: Make kvm_set_spte_hva() return int |
| |
Hi Paul: Thanks for your review. On Wed, Dec 12, 2018 at 1:03 PM Paul Mackerras <paulus@ozlabs.org> wrote: > > On Thu, Dec 06, 2018 at 09:21:10PM +0800, lantianyu1986@gmail.com wrote: > > From: Lan Tianyu <Tianyu.Lan@microsoft.com> > > > > The patch is to make kvm_set_spte_hva() return int and caller can > > check return value to determine flush tlb or not. > > It would be helpful if the patch description told the reader which > return value(s) mean that the caller should flush the tlb. I would > guess that non-zero means to do the flush, but you should make that > explicit.
OK. Thanks for suggestion and will update in the next version.
> > > Signed-off-by: Lan Tianyu <Tianyu.Lan@microsoft.com> > > For the powerpc bits: > > Acked-by: Paul Mackerras <paulus@ozlabs.org>
-- Best regards Tianyu Lan
| |