lkml.org 
[lkml]   [2018]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6 0/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
Date
Hi Matwey,

Thank you for the patches.

For the whole series,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

On Friday, 9 November 2018 21:03:25 EET Matwey V. Kornilov wrote:
> DMA cocherency slows the transfer down on systems without hardware coherent
> DMA. In order to demontrate this we introduce performance measurement
> facilities in patch 1 and fix the performance issue in patch 2 in order to
> obtain 3.3 times speedup.
>
> Changes since v5:
> * add dma_sync_single_for_device() as required by Laurent Pinchart
>
> Changes since v4:
> * fix fields order in trace events
> * minor style fixes
>
> Changes since v3:
> * fix scripts/checkpatch.pl errors
> * use __string to store name in trace events
>
> Changes since v2:
> * use dma_sync_single_for_cpu() to achive better performance
> * remeasured performance
>
> Changes since v1:
> * trace_pwc_handler_exit() call moved to proper place
> * detailed description added for commit 1
> * additional output added to trace to track separate frames
>
> Matwey V. Kornilov (2):
> media: usb: pwc: Introduce TRACE_EVENTs for pwc_isoc_handler()
> media: usb: pwc: Don't use coherent DMA buffers for ISO transfer
>
> drivers/media/usb/pwc/pwc-if.c | 69 +++++++++++++++++++++++++++++++--------
> include/trace/events/pwc.h | 65 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 121 insertions(+), 13 deletions(-)
> create mode 100644 include/trace/events/pwc.h

--
Regards,

Laurent Pinchart



\
 
 \ /
  Last update: 2018-12-12 18:28    [W:0.070 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site