lkml.org 
[lkml]   [2018]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 perf, bpf-next 1/4] perf, bpf: Introduce PERF_RECORD_BPF_EVENT
Date


> On Dec 12, 2018, at 4:06 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Tue, Dec 11, 2018 at 03:33:47PM -0800, Song Liu wrote:
>> +static void perf_event_bpf_output(struct perf_event *event,
>> + void *data)
>> +{
>> + struct perf_bpf_event *bpf_event = data;
>> + struct perf_output_handle handle;
>> + struct perf_sample_data sample;
>> + char name[KSYM_NAME_LEN];
>> + int name_len;
>> + int ret;
>> +
>> + if (!perf_event_bpf_match(event))
>> + return;
>> +
>> + /* get prog name and round up to 64 bit aligned */
>> + bpf_get_prog_name(bpf_event->prog, name);
>> + name_len = strlen(name) + 1;
>> + while (!IS_ALIGNED(name_len, sizeof(u64)))
>> + name[name_len++] = '\0';
>
> Does this not require something like:
>
> BUILD_BUG_ON(KSYM_NAME_LEN % sizeof(u64));

Yeah, this makes sense. I will add this in next version.

Thanks,
Song

\
 
 \ /
  Last update: 2018-12-12 17:50    [W:0.062 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site