Messages in this thread | | | Date | Wed, 12 Dec 2018 12:02:34 +0100 | From | Greg KH <> | Subject | Re: [PATCH v2 3/6] misc: fastrpc: Add support for context Invoke method |
| |
On Fri, Dec 07, 2018 at 04:35:10PM +0000, Srinivas Kandagatla wrote: > +#define FASTRPC_BUILD_SCALARS(attr, method, in, out, oin, oout) \ > + ((((uint32_t) (attr) & 0x07) << 29) | \ > + (((uint32_t) (method) & 0x1f) << 24) | \
Why all of the uint32_t and uint64_t types in this patch, but not the previous one?
Please just stick with u32 and u64, those are the correct kernel types to be using everywhere. uint32_t and friends are userspace things that make no sense in kernel space.
Yes, I know people use them, but we should not be adding to the problem by creating new instances of them for no good reason.
thanks,
greg k-h
| |