lkml.org 
[lkml]   [2018]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 24/91] kobject: Replace strncpy with memcpy
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Guenter Roeck <linux@roeck-us.net>

    commit 77d2a24b6107bd9b3bf2403a65c1428a9da83dd0 upstream.

    gcc 8.1.0 complains:

    lib/kobject.c:128:3: warning:
    'strncpy' output truncated before terminating nul copying as many
    bytes from a string as its length [-Wstringop-truncation]
    lib/kobject.c: In function 'kobject_get_path':
    lib/kobject.c:125:13: note: length computed here

    Using strncpy() is indeed less than perfect since the length of data to
    be copied has already been determined with strlen(). Replace strncpy()
    with memcpy() to address the warning and optimize the code a little.

    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    lib/kobject.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/lib/kobject.c
    +++ b/lib/kobject.c
    @@ -127,7 +127,7 @@ static void fill_kobj_path(struct kobjec
    int cur = strlen(kobject_name(parent));
    /* back up enough to print this name with '/' */
    length -= cur;
    - strncpy(path + length, kobject_name(parent), cur);
    + memcpy(path + length, kobject_name(parent), cur);
    *(path + --length) = '/';
    }


    \
     
     \ /
      Last update: 2018-12-11 17:20    [W:4.048 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site