lkml.org 
[lkml]   [2018]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 3/8] perf cs-etm: Remove unused 'trace_on' in cs_etm_decoder
    Date
    cs_etm_decoder::trace_on is being assigned when TRACE_ON or NO_SYNC
    element is coming, but it is never used hence it is redundant and can
    be removed.

    So let's remove 'trace_on' field from cs_etm_decoder struct.

    Suggested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Leo Yan <leo.yan@linaro.org>
    Cc: Mike Leach <mike.leach@linaro.org>
    Cc: Robert Walker <robert.walker@arm.com>
    ---
    tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
    index 0b4c862..97b39b1 100644
    --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
    +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
    @@ -36,7 +36,6 @@
    struct cs_etm_decoder {
    void *data;
    void (*packet_printer)(const char *msg);
    - bool trace_on;
    dcd_tree_handle_t dcd_tree;
    cs_etm_mem_cb_type mem_access;
    ocsd_datapath_resp_t prev_return;
    @@ -411,12 +410,10 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer(
    case OCSD_GEN_TRC_ELEM_UNKNOWN:
    break;
    case OCSD_GEN_TRC_ELEM_NO_SYNC:
    - decoder->trace_on = false;
    break;
    case OCSD_GEN_TRC_ELEM_TRACE_ON:
    resp = cs_etm_decoder__buffer_trace_on(decoder,
    trace_chan_id);
    - decoder->trace_on = true;
    break;
    case OCSD_GEN_TRC_ELEM_INSTR_RANGE:
    resp = cs_etm_decoder__buffer_range(decoder, elem,
    --
    2.7.4
    \
     
     \ /
      Last update: 2018-12-11 08:42    [W:4.213 / U:0.940 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site