lkml.org 
[lkml]   [2018]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:locking/core] locking/lockdep: Remove a superfluous INIT_LIST_HEAD() statement
    Commit-ID:  a66b6922dc6a5ece60ea9326153da3b062977a4d
    Gitweb: https://git.kernel.org/tip/a66b6922dc6a5ece60ea9326153da3b062977a4d
    Author: Bart Van Assche <bvanassche@acm.org>
    AuthorDate: Thu, 6 Dec 2018 17:11:35 -0800
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitDate: Tue, 11 Dec 2018 14:54:54 +0100

    locking/lockdep: Remove a superfluous INIT_LIST_HEAD() statement

    Initializing a list entry just before it is passed to list_add_tail_rcu()
    is not necessary because list_add_tail_rcu() overwrites the next and prev
    pointers anyway. Hence remove the INIT_LIST_HEAD() statement.

    Signed-off-by: Bart Van Assche <bvanassche@acm.org>
    Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Johannes Berg <johannes@sipsolutions.net>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Sasha Levin <sasha.levin@oracle.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Waiman Long <longman@redhat.com>
    Cc: johannes.berg@intel.com
    Cc: tj@kernel.org
    Link: https://lkml.kernel.org/r/20181207011148.251812-12-bvanassche@acm.org
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    kernel/locking/lockdep.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
    index 81388d028ac7..346b5a1fd062 100644
    --- a/kernel/locking/lockdep.c
    +++ b/kernel/locking/lockdep.c
    @@ -792,7 +792,6 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)
    class->key = key;
    class->name = lock->name;
    class->subclass = subclass;
    - INIT_LIST_HEAD(&class->lock_entry);
    INIT_LIST_HEAD(&class->locks_before);
    INIT_LIST_HEAD(&class->locks_after);
    class->name_version = count_matching_names(class);
    \
     
     \ /
      Last update: 2018-12-11 16:30    [W:5.349 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site