lkml.org 
[lkml]   [2018]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver
Date

Hi,

Roger Quadros <rogerq@ti.com> writes:
>> This patch introduce new Cadence USBSS DRD driver
>> to linux kernel.
>>
>> The Cadence USBSS DRD Driver is a highly
>> configurable IP Core which can be
>> instantiated as Dual-Role Device (DRD),
>> Peripheral Only and Host Only (XHCI)
>> configurations.
>>
>> The current driver has been validated with
>> FPGA burned. We have support for PCIe
>> bus, which is used on FPGA prototyping.
>>
>> The host side of USBSS-DRD controller is compliance
>> with XHCI specification, so it works with
>> standard XHCI linux driver.
>>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>> drivers/usb/Kconfig | 2 +
>> drivers/usb/Makefile | 2 +
>> drivers/usb/cdns3/Kconfig | 44 +
>> drivers/usb/cdns3/Makefile | 16 +
>> drivers/usb/cdns3/cdns3-pci-wrap.c | 157 +++
>> drivers/usb/cdns3/core.c | 451 +++++++
>> drivers/usb/cdns3/core.h | 108 ++
>> drivers/usb/cdns3/debug.h | 346 ++++++
>> drivers/usb/cdns3/debugfs.c | 168 +++
>> drivers/usb/cdns3/drd.c | 315 +++++
>> drivers/usb/cdns3/drd.h | 129 ++
>> drivers/usb/cdns3/ep0.c | 864 +++++++++++++
>> drivers/usb/cdns3/gadget-export.h | 28 +
>> drivers/usb/cdns3/gadget.c | 1802 ++++++++++++++++++++++++++++
>> drivers/usb/cdns3/gadget.h | 1177 ++++++++++++++++++
>> drivers/usb/cdns3/host-export.h | 28 +
>> drivers/usb/cdns3/host.c | 74 ++
>> drivers/usb/cdns3/trace.c | 11 +
>> drivers/usb/cdns3/trace.h | 343 ++++++
>
> You went to the other extreme of combining everything (host/gadget/drd) together
> which again makes this very hard to review.
>
> I think what Felipe meant was to only combine the gadget driver code
> into one patch.
>
> The series could be split into 6 patches like so.
> -dt binding
> -pci glue
> -core driver
> -host driver
> -gadget driver
> -drd driver

no, no. This is fine. We _could_ split out PCI glue to its own patch,
but it's rather pointless seing as it's so small.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-12-11 12:48    [W:0.345 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site