Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller | Date | Tue, 11 Dec 2018 13:41:25 -0800 |
| |
Wolfram Sang <wsa@the-dreams.de> writes:
>> I am okay if it is reasonable below in file >> arch/arm64/boot/dts/amlogic/meson-g12a.dtsi. I2c controller node just uses >> axg's compatible. >> >> i2c0: i2c@1f000 { >> compatible = "amlogic,meson-axg-i2c"; > > Actually, you should have > > compatible = "amlogic,meson-g12a-i2c", "amlogic,meson-axg-i2c"; > > in the DT to have support for future SoC specific additions. And then, > patch 1 is needed. > > Or do you handle this differently? I'd think this is DT standard.
It's a DT standard *if* there are actual hardware differences. In this case, the IP block is identical, so there are no driver changes.
We prefer to add a new compatible if and when there are actual driver/hardware changes.
Kevin
| |