lkml.org 
[lkml]   [2018]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] i2c-axxia: support sequence command mode
    Hi,

    > +static void axxia_i2c_handle_seq_nak(struct axxia_i2c_dev *idev)
    > +{
    > + while (readl(idev->base + MST_COMMAND) & CMD_BUSY)
    > + udelay(100);
    > +}

    My code checkers rightfully complain about this:

    CHECKPATCH
    CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt

    SMATCH
    drivers/i2c/busses/i2c-axxia.c:382 axxia_i2c_handle_seq_nak() warn: this loop depends on readl() succeeding

    (and I get those as well, but not related to your patch; still while I am here)

    GCC
    drivers/i2c/busses/i2c-axxia.c:98: warning: cannot understand function prototype: 'struct axxia_i2c_dev '
    drivers/i2c/busses/i2c-axxia.c:130: warning: Function parameter or member 'ns' not described in 'ns_to_clk'
    drivers/i2c/busses/i2c-axxia.c:130: warning: Function parameter or member 'clk_mhz' not described in 'ns_to_clk'
    drivers/i2c/busses/i2c-axxia.c:229: warning: Function parameter or member 'idev' not described in 'axxia_i2c_empty_rx_fifo'
    drivers/i2c/busses/i2c-axxia.c:261: warning: Function parameter or member 'idev' not described in 'axxia_i2c_fill_tx_fifo'

    Also, for $subject, please change the prefix to "i2c: axxia:"

    Thanks,

    Wolfram

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2018-12-11 21:04    [W:4.389 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site