Messages in this thread | | | Subject | Re: [PATCH net-next] ieee802154: ca8210: fix possible u8 overflow in ca8210_rx_done | From | Stefan Schmidt <> | Date | Tue, 11 Dec 2018 09:26:37 +0100 |
| |
Hello Dave.
On 11.12.18 07:01, David Miller wrote: > From: YueHaibing <yuehaibing@huawei.com> > Date: Tue, 11 Dec 2018 11:13:39 +0800 > >> gcc warning this: >> >> drivers/net/ieee802154/ca8210.c:730:10: warning: >> comparison is always false due to limited range of data type [-Wtype-limits] >> >> 'len' is u8 type, we get it from buf[1] adding 2, which can overflow. >> This patch change the type of 'len' to unsigned int to avoid this,also fix >> the gcc warning. >> >> Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> > > WPAN maintainers, I am assuming that as maintainers you will be > picking this up and sending it to me.
That's correct. On driver patches I always wait 2 days or so to give the driver maintainer a chance to reply before I go ahead and apply it.
I will take this one directly now and do some smoke testing. It will come together with another fix as pull request to you.
regards Stefan Schmidt
| |