Messages in this thread | | | Subject | Re: [PATCH] mtip32xx: avoid using semaphores | From | Jens Axboe <> | Date | Mon, 10 Dec 2018 14:44:39 -0700 |
| |
On 12/10/18 2:34 PM, Arnd Bergmann wrote: > The "cmd_slot_unal" semaphore is never used in a blocking way > but only as an atomic counter. Change the code to using > atomic_dec_if_positive() as a better API.
Looks good to me. We should also convert the return to blk-mq when we hit failure here to BLK_STS_DEV_RESOURCE, but that's a separate patch.
-- Jens Axboe
| |