Messages in this thread | | | Date | Mon, 10 Dec 2018 07:04:06 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v8 2/2] mfd: axp20x: Add supported cells for AXP803 |
| |
On Mon, 10 Dec 2018, Chen-Yu Tsai wrote:
> On Mon, Dec 10, 2018 at 2:35 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > On Sat, 08 Dec 2018, Oskari Lemmela wrote: > > > > > Parts of the AXP803 are compatible with their counterparts on the AXP813. > > > These include the GPIO, ADC, AC and battery power supplies. > > > > > > Signed-off-by: Oskari Lemmela <oskari@lemmela.net> > > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > > Tested-by: Vasily Khoruzhick <anarsoul@gmail.com> > > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > > > > I'm happy to fix this, but ... > > > > Can you explain these tags for me please? > > > > Specifically the last one. > > > > Why does Chen-Yu Tsai have an SoB there? > > I picked his patch to rebase off the previous one, and reworked the ordering. > I then pushed it onto GitHub [1], but didn't get around to sending it to the > mailing lists. Oskari said on IRC that he would handle it. > > I'm not sure what would be appropriate here though? Oskari's first SoB should > be kept, since he's the original author. Maybe he should've added his SoB > again as the final entry? Either way I suppose it would be confusing without > any explanation.
Yes, I agree, but thanks for taking the time to do so.
Let's leave it as it is.
> [1] https://github.com/wens/linux/commit/951afe2dc32086174ab07a1a997d748f69bf5bf2 > [2] https://freenode.irclog.whitequark.org/linux-sunxi/2018-12-08#23644905;
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |