lkml.org 
[lkml]   [2018]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 14/18] mfd: wm831x-i2c: Make it explicitly non-modular
    On Fri, Dec 07, 2018 at 03:11:01PM -0500, Paul Gortmaker wrote:
    > The Kconfig currently controlling compilation of this code is:
    >
    > drivers/mfd/Kconfig:config MFD_WM831X_I2C
    > drivers/mfd/Kconfig: bool "Wolfson Microelectronics WM831x/2x PMICs with I2C"
    >
    > ...meaning that it currently is not being built as a module by anyone.
    >
    > Lets remove the modular code that is essentially orphaned, so that
    > when reading the driver there is no doubt it is builtin-only.
    >
    > We explicitly disallow a driver unbind, since that doesn't have a
    > sensible use case anyway, and it allows us to drop the ".remove"
    > code for non-modular drivers.
    >
    > Since module_init was not in use by this code, the init ordering
    > remains unchanged with this commit.
    >
    > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
    >
    > Cc: Lee Jones <lee.jones@linaro.org>
    > Cc: patches@opensource.cirrus.com
    > Acked-by: Linus Walleij <linus.walleij@linaro.org>
    > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    > ---

    Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

    Thanks,
    Charles

    \
     
     \ /
      Last update: 2018-12-10 10:26    [W:4.224 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site