lkml.org 
[lkml]   [2018]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] irqchip: sifive-plic: Pre-compute context hart base and enable base
On Mon, Oct 22, 2018 at 05:15:14PM +0530, Anup Patel wrote:
> This patch does following optimizations:
> 1. Pre-compute hart base for each context handler
> 2. Pre-compute enable base for each context handler

Why?

> 3. Have enable lock for each context handler instead
> of global plic_toggle_lock

Why? Also even if you want this it should be a separate patch.

> #define PRIORITY_BASE 0
> -#define PRIORITY_PER_ID 4
> +#define PRIORITY_PER_ID 4

Also please drop the random whitespace changes.

\
 
 \ /
  Last update: 2018-11-09 09:43    [W:0.070 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site