Messages in this thread | | | Date | Fri, 9 Nov 2018 13:40:43 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH v4 01/18] arm64: dts: qcom: qcs404: add base dts files |
| |
On 09-11-18, 10:30, Vinod Koul wrote:
> > > + clocks { > > > + xo_board: xo_board { > > > > Build your dtbs with "W=12" and fix any warnings. You should get a > > warning about '_'. > > I did built it with W=1 though, so _ is not allowed?
I have fixed most of these with the exception of mmc-ddr-1_8v, as this is documented in mmc bindings, so cant change this one. For this one I am going to update gcc driver as well
> > > + cpus { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + CPU0: cpu@0 { > > > > unit address is wrong. > > Sorry am not sure I follow, can you please explain how..
Fixed now, thanks to Bjorn.
> > > + memory@80000000 { > > > + device_type = "memory"; > > > + /* We expect the bootloader to fill in the reg */ > > > > Can't you put in a default or base address at least. > > Okay will try
Added now, will send update shortly
-- ~Vinod
| |