lkml.org 
[lkml]   [2018]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 078/114] PM / devfreq: tegra: fix error return code in tegra_devfreq_probe()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 9e578b37505018622dfafc40eed7cd78ff2af221 ]

    platform_get_irq() returns an error code, but the tegra-devfreq
    driver ignores it and always returns -ENODEV. This is not correct,
    and prevents -EPROBE_DEFER from being propagated properly.

    Notice that platform_get_irq() no longer returns 0 on error:
    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

    Print and propagate the return value of platform_get_irq on failure.

    Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
    Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
    Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/devfreq/tegra-devfreq.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
    index 848b93ee930f..64a2e02b87d7 100644
    --- a/drivers/devfreq/tegra-devfreq.c
    +++ b/drivers/devfreq/tegra-devfreq.c
    @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
    }

    irq = platform_get_irq(pdev, 0);
    - if (irq <= 0) {
    - dev_err(&pdev->dev, "Failed to get IRQ\n");
    - return -ENODEV;
    + if (irq < 0) {
    + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
    + return irq;
    }

    platform_set_drvdata(pdev, tegra);
    --
    2.17.1


    \
     
     \ /
      Last update: 2018-11-08 23:29    [W:3.630 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site