lkml.org 
[lkml]   [2018]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 055/171] ath10k: fix NAPI enable/disable symmetry for AHB interface
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit a7595a820b07db9ac0d8f479ff62002bdd32a05a ]

    Move NAPI enable to 'ath10k_ahb_hif_start' from
    'ath10k_ahb_hif_power_up'. This is to maintain the symmetry
    of calling napi_enable() from ath10k_ahb_hif_start() so that it
    matches with napi_disable() being called from ath10k_pci_hif_stop().

    This change is based on the crash fix from Kalle for PCI interface in
    commit 1427228d5869 ("ath10k: fix napi crash during rmmod when probe
    firmware fails").

    Signed-off-by: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
    Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/ath/ath10k/ahb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c
    index 45226dbee5ce..da770af83036 100644
    --- a/drivers/net/wireless/ath/ath10k/ahb.c
    +++ b/drivers/net/wireless/ath/ath10k/ahb.c
    @@ -640,6 +640,7 @@ static int ath10k_ahb_hif_start(struct ath10k *ar)
    {
    ath10k_dbg(ar, ATH10K_DBG_BOOT, "boot ahb hif start\n");

    + napi_enable(&ar->napi);
    ath10k_ce_enable_interrupts(ar);
    ath10k_pci_enable_legacy_irq(ar);

    @@ -692,7 +693,6 @@ static int ath10k_ahb_hif_power_up(struct ath10k *ar)
    ath10k_err(ar, "could not wake up target CPU: %d\n", ret);
    goto err_ce_deinit;
    }
    - napi_enable(&ar->napi);

    return 0;

    --
    2.17.1


    \
     
     \ /
      Last update: 2018-11-08 23:26    [W:3.911 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site