Messages in this thread | | | Date | Fri, 9 Nov 2018 08:42:18 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 1/7] tty: Fix whitespace before tab warnings |
| |
On Fri, Oct 19, 2018 at 09:37:01AM +1100, Tobin C. Harding wrote: > This patch is whitespace only. > > Checkpatch emits a BUNCH of warnings of type > > WARNING: please, no spaces at the start of a line > WARNING: please, no space before tabs > > While these may seem trivial they hinder further cleanup efforts because > there are so many that later cleanup touches many of the same lines, > this makes the cleanup patches super noisy when parsed with > checkpatch (although checkpatching this series is prohibitively noisy > even with this patch). > > In preparation for doing kernel-docs cleanup fix all the whitespace > before tab and whitespace at start of line warnings. We do not fix any > that are obviously there for extra-ordinary formatting reasons. > > Any line in the diff with obvious other formatting errors is fixed also > excluding kernel-docs lines. > > Signed-off-by: Tobin C. Harding <tobin@kernel.org> > --- > > Actually, checkpatch is only noisy on a couple of patches from this > set. I ran checkpatch individually (instead of on the whole set) on > each patch and fixed things within scope of this set while working on > version 2 of the set. > > drivers/tty/amiserial.c | 43 ++++--- > drivers/tty/hvc/hvc_console.c | 2 +- > drivers/tty/ipwireless/tty.c | 2 +- > drivers/tty/isicom.c | 4 +- > drivers/tty/moxa.c | 30 +++-- > drivers/tty/mxser.c | 10 +- > drivers/tty/n_hdlc.c | 10 +- > drivers/tty/rocket.c | 8 +- > drivers/tty/serdev/core.c | 2 +- > drivers/tty/serial/8250/8250_dw.c | 4 +- > drivers/tty/serial/amba-pl011.c | 8 +- > drivers/tty/serial/cpm_uart/cpm_uart_core.c | 8 +- > drivers/tty/serial/icom.c | 5 +- > drivers/tty/serial/ip22zilog.c | 2 +- > drivers/tty/serial/jsm/jsm_neo.c | 2 +- > drivers/tty/serial/mux.c | 6 +- > drivers/tty/serial/mxs-auart.c | 2 +- > drivers/tty/serial/pmac_zilog.c | 4 +- > drivers/tty/serial/pxa.c | 20 +-- > drivers/tty/serial/serial_txx9.c | 2 +- > drivers/tty/serial/sn_console.c | 38 +++--- > drivers/tty/serial/sunsab.c | 2 +- > drivers/tty/serial/sunsu.c | 4 +- > drivers/tty/serial/sunzilog.c | 2 +- > drivers/tty/serial/ucc_uart.c | 134 ++++++++++---------- > drivers/tty/serial/vr41xx_siu.c | 2 +- > drivers/tty/serial/zs.c | 12 +- > drivers/tty/sysrq.c | 34 ++--- > drivers/tty/tty_baudrate.c | 2 +- > drivers/tty/tty_io.c | 22 ++-- > drivers/tty/tty_ioctl.c | 2 +- > drivers/tty/tty_jobctrl.c | 8 +- > drivers/tty/vt/consolemap.c | 6 +- > drivers/tty/vt/keyboard.c | 29 +++-- > drivers/tty/vt/selection.c | 12 +- > drivers/tty/vt/vt.c | 40 +++--- > drivers/tty/vt/vt_ioctl.c | 14 +- > 37 files changed, 271 insertions(+), 266 deletions(-)
The hard part about doing large patches like this that cross lots of files is that it usually does not end up applying. This patch currently fails against 4.20-rc1 :(
But, if it were divided up into "one patch per driver" then I could have applied the majority of them, as only a few drivers changed to require this series to be rebased and reworked.
I really want to apply this patch series, but as-is, it just can't even apply... Can you rebase/break up the patches into smaller ones so that we have a chance to get them merged eventually?
thanks,
greg k-h
| |