Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH v2] x86/cpu: fix prototype warning | Date | Fri, 9 Nov 2018 16:07:01 +0000 |
| |
From: Thomas Gleixner > Sent: 08 November 2018 15:36 > On Thu, 8 Nov 2018, Borislav Petkov wrote: > > And frankly, I don't see why we should be fixing all those. So what if a > > global function does't have a previous prototype declaration?! > > Global function declarations must have a prototype definition, really. > > Otherwise you can change the function signature and all callers which use > the old unchanged prototype are hosed.
I bet there are at least double-figures of real bugs out there.
The next on the list should be -Wwriteable-strings. Usually just needs a few 'const' sprinkled.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |