Messages in this thread | | | Subject | Re: [PATCH 1/2] ASoC: pcm3060: Add control for differential output | From | Kirill Marinushkin <> | Date | Fri, 9 Nov 2018 14:06:50 +0100 |
| |
Hello Mark,
On 11/05/18 12:20, Mark Brown wrote: > On Mon, Oct 29, 2018 at 09:59:12AM +0100, Kirill Marinushkin wrote: >> DAC may be switched between differential and single-ended output. > > Isn't this something that'd be better controlled by DT - it's usually > going to be part of the board design? >
I agree with that. I implemented it as a switch, just because that's how other codec drivers do. In such situations, I prefer to be aligned with already existing code.
Indeed, it's more logical to implement such setup via DT. I will rewrite and send it as patch v2.
Best Regards, Kirill
| |