Messages in this thread | | | Date | Fri, 9 Nov 2018 03:24:34 -0800 | From | Greg KH <> | Subject | Re: [PATCH] drivers/android/binder.c: Remove duplicate header |
| |
On Fri, Nov 09, 2018 at 09:44:25AM +0530, Brajeswar Ghosh wrote: > Remove binder_trace.h which is included more than once > > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com> > --- > drivers/android/binder.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > index cb30a524d16d..719f35a5c04b 100644 > --- a/drivers/android/binder.c > +++ b/drivers/android/binder.c > @@ -5852,6 +5852,5 @@ static int __init binder_init(void) > device_initcall(binder_init); > > #define CREATE_TRACE_POINTS > -#include "binder_trace.h" > > MODULE_LICENSE("GPL v2");
Are you sure about this? Did you test the tracepoint functionality after removing that line? I think you just broke it :(
thanks,
greg k-h
| |