Messages in this thread | | | Date | Thu, 8 Nov 2018 08:50:42 +0200 | From | Matti Vaittinen <> | Subject | Re: [PATCH] regulator: bd71837: add <linux/of.h> to fix build errors |
| |
Thanks Randy,
On Wed, Nov 07, 2018 at 08:38:50AM -0800, Randy Dunlap wrote: > On 10/25/18 11:02 PM, Vaittinen, Matti wrote: > > Hello, > > > > From: Randy Dunlap <rdunlap@infradead.org> > > > >> Fix build error due to missing header file: > >> > >> drivers/regulator/bd71837-regulator.c:242:3: error: implicit declaration of function 'of_match_ptr' [-Werror=implicit-function-declaration] > >> > >> Fixes: ba08799e90b5 ("regulator: bd71837: BD71837 PMIC regulator driver") > > > > //snip > > > >> --- lnx-419.orig/drivers/regulator/bd71837-regulator.c > >> +++ lnx-419/drivers/regulator/bd71837-regulator.c > >> @@ -9,6 +9,7 @@ > >> #include <linux/kernel.h> > >> #include <linux/mfd/rohm-bd718x7.h> > >> #include <linux/module.h> > >> +#include <linux/of.h> > >> #include <linux/platform_device.h> > >> #include <linux/regulator/driver.h> > >> #include <linux/regulator/machine.h> > > > > Not sure if this is relevant but if I am not mistaken this should already be fixed by: > > df43519eb706edfe951284a825642ce2e1d38d09 > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=df43519eb706edfe951284a825642ce2e1d38d09 > > > > > > Br, > > Matti Vaittinen > > > > Hi, > > It seems that this same patch is now needed in > drivers/regulator/bd718x7-regulator.c:
Noticed same thing. Few fixes seem to be lost when pickable ranges and bd71847 support was added. Sent this: https://lore.kernel.org/lkml/20181029121630.GA11183@localhost.localdomain/ to Mark few days ago. I guess this fix should end up in 4.20?
Br, Matti Vaittinen
-- Matti Vaittinen ROHM Semiconductors
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
| |