Messages in this thread | | | Subject | Re: [PATCH 1/3] i3c: master: Add driver for Synopsys DesignWare IP | From | vitor <> | Date | Wed, 7 Nov 2018 17:16:01 +0000 |
| |
Hi Geert,
On 07/11/18 15:34, Geert Uytterhoeven wrote: > Hi Vitor, > > On Wed, Nov 7, 2018 at 4:15 PM vitor <vitor.soares@synopsys.com> wrote: >> On 29/10/18 13:41, Matthew Wilcox wrote: >>> On Mon, Oct 29, 2018 at 10:06:56AM +0000, Vitor soares wrote: >>>> +config DW_I3C_MASTER >>>> + tristate "Synospsys DesignWare I3C master driver" >>>> + depends on I3C >>>> + depends on !(ALPHA || PARISC) >>> why? >> Please check this email thread: https://urldefense.proofpoint.com/v2/url?u=https-3A__lkml.org_lkml_2018_10_8_393&d=DwIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=qVuU64u9x77Y0Kd0PhDK_lpxFgg6PK9PateHwjb_DY0&m=dVPXOATdi751iTXEXYcWuChJA6hcIkXr8tF-i9hrv4E&s=Nk3lXNpRMzhvKMnlXUsFySTr5VYAr2228vXaZfiGBgM&e= > Hence this deserves a comment, so we know when/what to do to drop the > dependency: > > depends on !(ALPHA || PARISC) # needs {read,write}sl() > > Gr{oetje,eeting}s, > > Geert > I agree with you, I just didn't know if I should comment or not. I will do that next version.
Best regards,
Vitor Soares
| |