lkml.org 
[lkml]   [2018]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rtc: hctosys: Add missing range error reporting
On 05/11/2018 03:48:25+0000, Maciej W. Rozycki wrote:
> Fix an issue with the 32-bit range error path in `rtc_hctosys' where no
> error code is set and consequently the successful preceding call result
> from `rtc_read_time' is propagated to `rtc_hctosys_ret'. This in turn
> makes any subsequent call to `hctosys_show' incorrectly report in sysfs
> that the system time has been set from this RTC while it has not.
>
> Set the error to ERANGE then if we can't express the result due to an
> overflow.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> Fixes: b3a5ac42ab18 ("rtc: hctosys: Ensure system time doesn't overflow time_t")
> Cc: stable@vger.kernel.org # 4.17+
> ---
> drivers/rtc/hctosys.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Applied, thanks.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

\
 
 \ /
  Last update: 2018-11-07 17:24    [W:0.044 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site