Messages in this thread | | | Date | Wed, 7 Nov 2018 12:26:50 +0100 | From | Greg KH <> | Subject | Re: [PATCH] staging: mt7621-mmc: Add blank line after declaration |
| |
On Tue, Nov 06, 2018 at 10:42:42PM -0200, nicolas@autobyte.com.br wrote: > From: Nícolas F. R. A. Prado <nfraprado@protonmail.com> > > Correct the following warning from checkpatch.pl: > > WARNING: Missing a blank line after declarations > + struct msdc_host *host = mmc_priv(mmc); > + msdc_pm(state, (void *)host); > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@protonmail.com> > > --- > > Hi, this is my first commit. Let me know if there's anything I can do > better. > --- > drivers/staging/mt7621-mmc/sd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c > index 0379f9c96..7b66f9b0a 100644 > --- a/drivers/staging/mt7621-mmc/sd.c > +++ b/drivers/staging/mt7621-mmc/sd.c > @@ -1797,6 +1797,7 @@ static void msdc_drv_pm(struct platform_device *pdev, pm_message_t state) > > if (mmc) { > struct msdc_host *host = mmc_priv(mmc); > + > msdc_pm(state, (void *)host); > }
This patch is fine, and I'll take it, but can't this be written a lot simpler: if (mmc) msdc_pm(state, mmc_priv(mmc));
that looks better, don't you think?
thanks,
greg k-h
| |