lkml.org 
[lkml]   [2018]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] MIPS: SiByte: Enable swiotlb for SWARM and BigSur
On Wed, 7 Nov 2018, Christoph Hellwig wrote:

> Do we really need a new source file just to call swiotlb_init?

I think it being a separate file is actually good, as it saves a little
bit of code space at run time if this is not used without the need to
wrap the entire function into #ifdef.

> And
> if we do that file should have a SPDX header these days.

It does or I have missed something.

Thanks for your review.

Maciej

\
 
 \ /
  Last update: 2018-11-07 12:14    [W:0.048 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site