Messages in this thread | | | Date | Wed, 7 Nov 2018 11:14:00 +0000 (GMT) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH 2/2] MIPS: SiByte: Enable swiotlb for SWARM and BigSur |
| |
On Wed, 7 Nov 2018, Christoph Hellwig wrote:
> Do we really need a new source file just to call swiotlb_init?
I think it being a separate file is actually good, as it saves a little bit of code space at run time if this is not used without the need to wrap the entire function into #ifdef.
> And > if we do that file should have a SPDX header these days.
It does or I have missed something.
Thanks for your review.
Maciej
| |