Messages in this thread | | | From | "Liu, Yi L" <> | Subject | RE: [PATCH v4 06/12] iommu/vt-d: Add second level page table interface | Date | Wed, 7 Nov 2018 07:13:46 +0000 |
| |
Hi Baolu,
> From: Lu Baolu [mailto:baolu.lu@linux.intel.com] > Sent: Monday, November 5, 2018 1:32 PM > > This adds the interfaces to setup or tear down the structures > for second level page table translations. This includes types > of second level only translation and pass through.
A little bit refining to the description:) "This patch adds interfaces for setup or tear down second level translation in PASID granularity. Translation type includes second level only type and pass-through type."
> Cc: Ashok Raj <ashok.raj@intel.com> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> > Cc: Kevin Tian <kevin.tian@intel.com> > Cc: Liu Yi L <yi.l.liu@intel.com> > Signed-off-by: Sanjay Kumar <sanjay.k.kumar@intel.com>
[...]
> + > +void intel_pasid_tear_down_entry(struct intel_iommu *iommu, > + struct device *dev, int pasid) > +{ > + struct pasid_entry *pte;
pte is confusing as it is similar with pte in paging structures. may use pt_entry or just pasid_entry. This comment applies to other "pte"s in this patch.
Thanks, Yi Liu
| |