Messages in this thread | | | Date | Tue, 6 Nov 2018 17:04:33 -0500 | From | "Theodore Y. Ts'o" <> | Subject | Re: [PATCH v2 08/11] ext4: lost brelse in ext4_orphan_add() |
| |
On Wed, Oct 31, 2018 at 12:58:31AM +0300, Vasily Averin wrote: > iloc.bh os taken in ext4_reserve_inode_write(). > If (dirty == true) it is released in ext4_mark_iloc_dirty(), > however it is not released in (dirty == false) case. > > Fixes d745a8c20c1f ("ext4: reduce contention on s_orphan_lock") > however iloc.bh count balance was broken earlier by > Fixes 6e3617e579e0 ("ext4: Handle non empty on-disk orphan link") #2.6.34 > > cc: Dmitry Monakhov <dmonakhov@gmail.com> > Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Thanks, applied. I fixed up the commit description and Fixes/Cc trailers. I used the one-line description:
ext4: avoid buffer leak in ext4_orphan_add() after prior errors
- Ted
| |