lkml.org 
[lkml]   [2018]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/10] drm/sun4i: sun6i_mipi_dsi: Support instruction loop selection
    On Mon, Nov 05, 2018 at 04:56:35PM +0530, Jagan Teki wrote:
    > On Mon, Nov 5, 2018 at 4:09 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
    > >
    > > On Sat, Nov 03, 2018 at 03:38:52PM +0530, Jagan Teki wrote:
    > > > Instruction loop selection would require before writing
    > > > loop number registers, so enable idle, LP11 bits on
    > > > loop selection register.
    > > >
    > > > Reference code available in BSP
    > > > (in drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c)
    > > > (dsi_dev[sel]->dsi_inst_loop_sel.dwval = 2<<(4*DSI_INST_ID_LP11) |
    > > > 3<<(4*DSI_INST_ID_DLY);
    > > >
    > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
    > > > ---
    > > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 ++++
    > > > 1 file changed, 4 insertions(+)
    > > >
    > > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
    > > > index da152c21ec62..077b57ec964c 100644
    > > > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
    > > > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
    > > > @@ -397,6 +397,10 @@ static void sun6i_dsi_setup_inst_loop(struct sun6i_dsi *dsi,
    > > > struct mipi_dsi_device *device = dsi->device;
    > > > u16 delay;
    > > >
    > > > + regmap_write(dsi->regs, SUN6I_DSI_INST_LOOP_SEL_REG,
    > > > + DSI_INST_ID_HSC << (4 * DSI_INST_ID_LP11) |
    > > > + DSI_INST_ID_HSD << (4 * DSI_INST_ID_DLY));
    > > > +
    > >
    > > Please put this with the other instructions settings below.
    >
    > Does that mean after computation delay code?

    Yes

    Maxime

    --
    Maxime Ripard, Bootlin
    Embedded Linux and Kernel engineering
    https://bootlin.com
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2018-11-06 16:53    [W:2.503 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site