Messages in this thread | | | Subject | Re: [PATCH v3 2/2] mm/page_alloc: use a single function to free page | From | Vlastimil Babka <> | Date | Tue, 6 Nov 2018 13:06:24 +0100 |
| |
On 11/6/18 12:31 PM, Aaron Lu wrote: > We have multiple places of freeing a page, most of them doing similar > things and a common function can be used to reduce code duplicate. > > It also avoids bug fixed in one function but left in another. > > Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Thanks!
> --- > v3: Vlastimil mentioned the possible performance loss by using > page_ref_sub_and_test(page, 1) for put_page_testzero(page), since > we aren't sure so be safe by keeping page ref decreasing code as > is, only move freeing page part to a common function.
| |