Messages in this thread Patch in this message | | | Subject | [PATCH 1/6] fuse: Kill fasync only if interrupt is queued in queue_interrupt() | From | Kirill Tkhai <> | Date | Tue, 06 Nov 2018 12:30:33 +0300 |
| |
We should sent signal only in case of interrupt is really queued. Not a real problem, but this makes the code clearer and intuitive.
Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com> --- fs/fuse/dev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index fb2530ed84b3..7705f75c77a3 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -468,6 +468,8 @@ static void request_end(struct fuse_conn *fc, struct fuse_req *req) static void queue_interrupt(struct fuse_iqueue *fiq, struct fuse_req *req) { + bool kill = false; + spin_lock(&fiq->waitq.lock); if (test_bit(FR_FINISHED, &req->flags)) { spin_unlock(&fiq->waitq.lock); @@ -476,9 +478,11 @@ static void queue_interrupt(struct fuse_iqueue *fiq, struct fuse_req *req) if (list_empty(&req->intr_entry)) { list_add_tail(&req->intr_entry, &fiq->interrupts); wake_up_locked(&fiq->waitq); + kill = true; } spin_unlock(&fiq->waitq.lock); - kill_fasync(&fiq->fasync, SIGIO, POLL_IN); + if (kill) + kill_fasync(&fiq->fasync, SIGIO, POLL_IN); } static void request_wait_answer(struct fuse_conn *fc, struct fuse_req *req)
| |