Messages in this thread | | | Date | Tue, 06 Nov 2018 11:15:13 -0800 (PST) | Subject | Re: [PATCH] staging: net: ipv4: tcp_westwood: fixed warnings and checks | From | David Miller <> |
| |
From: Suraj Singh <suraj1998@gmail.com> Date: Mon, 5 Nov 2018 19:23:05 +0530
> Fixed warnings and checks for TCP Westwood > > Signed-off-by: Suraj Singh <suraj1998@gmail.com>
I asked you yesterday why "staging: " appears in your subject line and you have failed to respond and explain.
There are also functional issues with your patch:
> - tp->snd_cwnd = tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk); > + tp->snd_cwnd = tcp_westwood_bw_rttmin(sk); > + tp->snd_ssthresh = tcp_westwood_bw_rttmin(sk);
This is bogus, now tcp_westwood_bw_rttmin(sk) will potentially be called two times instead of once.
The existing code is fine, please do not modify it.
| |