lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bloat-o-meter: ignore __addressable_ symbols
On Fri, Nov 02, 2018 at 10:00:25PM +0100, Rasmus Villemoes wrote:
> Since __LINE__ is part of the symbol created by __ADDRESSABLE, almost
> any change causes those symbols to disappear and get reincarnated, e.g.
>
> add/remove: 4/4 grow/shrink: 0/3 up/down: 32/-171 (-139)
> Function old new delta
> __addressable_tracing_set_default_clock8649 - 8 +8
> __addressable_tracer_init_tracefs8631 - 8 +8
> __addressable_ftrace_dump8383 - 8 +8
> __addressable_clear_boot_tracer8632 - 8 +8
> __addressable_tracing_set_default_clock8650 8 - -8
> __addressable_tracer_init_tracefs8632 8 - -8
> __addressable_ftrace_dump8384 8 - -8
> __addressable_clear_boot_tracer8633 8 - -8
> trace_default_header 663 642 -21
> tracing_mark_raw_write 406 355 -51
> tracing_mark_write 624 557 -67
> Total: Before=63889, After=63750, chg -0.22%
>
> They're small and in .discard, so ignore them, leading to more useful
>
> add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-139 (-139)
> Function old new delta
> trace_default_header 663 642 -21
> tracing_mark_raw_write 406 355 -51
> tracing_mark_write 624 557 -67
> Total: Before=63721, After=63582, chg -0.22%

Useful!

FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> scripts/bloat-o-meter | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
> index a923f05edb36..8c965f6a9881 100755
> --- a/scripts/bloat-o-meter
> +++ b/scripts/bloat-o-meter
> @@ -32,6 +32,7 @@ def getsizes(file, format):
> if name.startswith("__mod_"): continue
> if name.startswith("__se_sys"): continue
> if name.startswith("__se_compat_sys"): continue
> + if name.startswith("__addressable_"): continue
> if name == "linux_banner": continue
> # statics and some other optimizations adds random .NUMBER
> name = re_NUMBER.sub('', name)
> --
> 2.19.1.6.gbde171bbf5
>

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2018-11-05 15:40    [W:0.045 / U:1.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site