lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] efi: Fix debugobjects warning on efi_rts_work
    On 23 October 2018 at 18:43, Prakhya, Sai Praneeth
    <sai.praneeth.prakhya@intel.com> wrote:
    >
    >
    >> -----Original Message-----
    >> From: Waiman Long [mailto:longman@redhat.com]
    >> Sent: Tuesday, October 23, 2018 7:18 AM
    >> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    >> Cc: linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org; Prakhya, Sai
    >> Praneeth <sai.praneeth.prakhya@intel.com>; Waiman Long
    >> <longman@redhat.com>
    >> Subject: [PATCH] efi: Fix debugobjects warning on efi_rts_work
    >>
    >> The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
    >> handler") converted efi_rts_work from an auto variable to a global variable.
    >> However, when submitting the work, INIT_WORK_ONSTACK() was still used
    >> causing the following complaint from debugobjects:
    >>
    >> ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760, but
    >> annotated.
    >>
    >> Change the macro to just INIT_WORK() to eliminate the warning.
    >>
    >> Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
    >> handler")
    >
    > Thanks for fixing this :)
    > Looks good to me.
    >
    > Regards,
    > Sai

    Thanks

    Queued in efi/urgent (with Sai's ack)

    \
     
     \ /
      Last update: 2018-11-05 14:02    [W:2.645 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site