lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2] ARM: dts: sun8i-h3: Add dts for the Mapleboard MP130
On Tue, Oct 30, 2018 at 10:14:30PM +0000, Jonathan McDowell wrote:
> + r_gpio_keys {
> + compatible = "gpio-keys";
> + pinctrl-names = "default";
> +
> + power {
> + label = "mp130:power";

That was my mistake, but it was correct in your first version.

> +&pio {
> + leds_pio: led_pins {
> + pins = "PA15";
> + function = "gpio_out";
> + };
> +};
> +
> +&r_pio {
> + leds_r_pio: led_pins {
> + pins = "PL10";
> + function = "gpio_out";
> + };
> +
> + sw_r_pio: key_pins {
> + pins = "PL3", "PL4";
> + function = "gpio_in";
> + };
> +};

You don't need these nodes at all.

I've fixed both issues and applied your patch for 4.21

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-11-05 10:06    [W:0.060 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site