Messages in this thread | | | Subject | Re: [PATCH v1 3/7] vfio: ap: AP Queue Interrupt structures definitions | From | Pierre Morel <> | Date | Mon, 5 Nov 2018 09:46:56 +0100 |
| |
On 02/11/2018 16:14, Tony Krowiak wrote: > On 10/31/18 2:12 PM, Pierre Morel wrote: >> We define all the structures we need to let GISA handle >> the AP Queues Interrupt.
...
>> +struct aqic_gisa { >> + uint8_t rzone; >> + uint8_t izone; >> + unsigned ir:1; >> + unsigned reserved1:4; >> + unsigned gisc:3; >> + unsigned reserved2:6; >> + unsigned f:2; >> + unsigned reserved3:1; >> + unsigned gisao:27; >> + unsigned t:1; >> + unsigned isc:3; >> +} __packed __aligned(8); > > This struct is redundant with the 'struct ap_qirq_ctrl' > defined in arch/s390/include/asm/ap.h. That file also includes > the asm for the ap_aqic function.
Exact. My code is quite old and I forgot to adapt it to the new definitions. I will do it for this, aqic, the inline assembler and the status.
Thanks,
Pierre
-- Pierre Morel Linux/KVM/QEMU in Böblingen - Germany
| |