lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/11] [media] marvell-ccic/mmp: enable clock before accessing registers
    Date
    The access to REG_CLKCTRL or REG_CTRL1 without the clock enabled hangs
    the machine. Enable the clock first.

    Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
    ---
    drivers/media/platform/marvell-ccic/mmp-driver.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c
    index 9e988e527b0d..9c0238f72c40 100644
    --- a/drivers/media/platform/marvell-ccic/mmp-driver.c
    +++ b/drivers/media/platform/marvell-ccic/mmp-driver.c
    @@ -145,6 +145,7 @@ static int mmpcam_power_up(struct mcam_camera *mcam)
    * Turn on power and clocks to the controller.
    */
    mmpcam_power_up_ctlr(cam);
    + mcam_clk_enable(mcam);
    /*
    * Provide power to the sensor.
    */
    @@ -158,8 +159,6 @@ static int mmpcam_power_up(struct mcam_camera *mcam)
    gpio_set_value(pdata->sensor_reset_gpio, 1); /* reset is active low */
    mdelay(5);

    - mcam_clk_enable(mcam);
    -
    return 0;
    }

    --
    2.19.1
    \
     
     \ /
      Last update: 2018-11-05 08:32    [W:4.343 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site