lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] x86/build: Build VSMP support only if CONFIG_PCI is selected
From
Date
Greetings Thomas,

On 11/04/2018 11:05 PM, Thomas Gleixner wrote:
> Eial,
>
> On Thu, 1 Nov 2018, Eial Czerwacki wrote:
>
>> Subject: x86/build: Build VSMP support only if CONFIG_PCI is selected
>
> That's not what the patch does, right?
>
you are correct, I'll resend it with a more appropriate subject.

>> vsmp dependency on pv_irq_ops removed some years ago, so now let's clean
>> it up from vsmp_64.c.
>>
>> In short, "cap & ctl & (1 << 4)" was always returning 0, as such we can
>> remove all the PARAVIRT/PARAVIRT_XXL code handling that.
>>
>> However, the rest of the code depends on CONFIG_PCI, so fix it accordingly.
>> in addition, rename set_vsmp_pv_ops to set_vsmp_ctl.
>>
>> Signed-off-by: Eial Czerwacki <eial@scalemp.com>
>> Acked-by: Shai Fultheim <shai@scalemp.com>
>
> Unfortunately that patch does not apply. It's white space damaged, i.e. all
> tabs are converted to spaces.
>
> Thanks,
>
> tglx
>

weird, it got applied without any issues on latest git, I'll verify it
applies well.

Eial.

\
 
 \ /
  Last update: 2018-11-05 07:41    [W:0.057 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site