lkml.org 
[lkml]   [2018]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] drm/ast: Fix connector leak during driver unload
Date
When unloading the ast driver, a warning message is printed by
drm_mode_config_cleanup() because a reference is still held to one of
the drm_connector structs.

Correct this by calling drm_framebuffer_remove() in
ast_fbdev_destroy().

Signed-off-by: Sam Bobroff <sbobroff@linux.ibm.com>
---
drivers/gpu/drm/ast/ast_fb.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index 0cd827e11fa2..655372ea81e9 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -263,6 +263,10 @@ static void ast_fbdev_destroy(struct drm_device *dev,
{
struct ast_framebuffer *afb = &afbdev->afb;

+ /* drm_framebuffer_remove() expects us to hold a ref, which it
+ * will drop, so take one: */
+ drm_framebuffer_get(&afb->base);
+ drm_framebuffer_remove(&afb->base);
drm_fb_helper_unregister_fbi(&afbdev->helper);

if (afb->obj) {
--
2.19.0.2.gcad72f5712
\
 
 \ /
  Last update: 2018-11-05 06:59    [W:0.095 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site