Messages in this thread | | | From | Vitaly Mayatskih <> | Date | Fri, 2 Nov 2018 15:24:13 -0400 | Subject | Re: [PATCH 1/1] Add vhost_blk driver |
| |
On Fri, Nov 2, 2018 at 2:36 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> > + if (type == VIRTIO_BLK_T_GET_ID) { > > + char s[] = "vhost_blk"; > > Isn't this supposed to return the serial #?
Yes, that gets a bit tricky here... Disk serial number is specified in QEMU command line parameters, so it needs to be passed to vhost_blk when qemu attaches the disk backend. That can be done (now? in a following incremental patch?). Also other vhost work does the same with GET_ID, if that's matter.
I'll fix the rest, thanks for review!
-- wbr, Vitaly
| |