lkml.org 
[lkml]   [2018]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/1] Add vhost_blk driver
On Fri, Nov 2, 2018 at 2:36 PM Michael S. Tsirkin <mst@redhat.com> wrote:

> > + if (type == VIRTIO_BLK_T_GET_ID) {
> > + char s[] = "vhost_blk";
>
> Isn't this supposed to return the serial #?

Yes, that gets a bit tricky here... Disk serial number is specified in
QEMU command line parameters, so it needs to be passed to vhost_blk
when qemu attaches the disk backend. That can be done (now? in a
following incremental patch?).
Also other vhost work does the same with GET_ID, if that's matter.

I'll fix the rest, thanks for review!

--
wbr, Vitaly

\
 
 \ /
  Last update: 2018-11-02 20:25    [W:0.124 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site