Messages in this thread | | | Date | Fri, 2 Nov 2018 23:44:51 +0100 | From | Petr Vorel <> | Subject | Re: [PATCH] kconfig: merge_config: avoid false positive matches from comment lines |
| |
Hi Masahiro,
> The current SED_CONFIG_EXP could match to comment lines in config > fragment files, especially when CONFIG_PREFIX_ is empty. For example, > Buildroot uses empty prefixing; starting symbols with BR2_ is just > convention.
> Make the sed expression more robust against false positives from > comment lines. The new sed expression matches to config options > followed by '=' or ' is not set'.
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
> -SED_CONFIG_EXP="s/^\(# \)\{0,1\}\(${CONFIG_PREFIX}[a-zA-Z0-9_]*\)[= ].*/\2/p" > +SED_CONFIG_EXP="s/^\(# \)\{0,1\}\(${CONFIG_PREFIX}[a-zA-Z0-9_]*\)\(=.*\| is not set$\)/\2/p"
Good idea, thanks!
Kind regards, Petr
| |