lkml.org 
[lkml]   [2018]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ubifs: replay: fix high stack usage
Date
Am Freitag, 2. November 2018, 16:39:24 CET schrieb Arnd Bergmann:
> Having two shash descriptors on the stack cause a very significant kernel
> stack usage that can cross the warning threshold:
>
> fs/ubifs/replay.c: In function 'authenticate_sleb':
> fs/ubifs/replay.c:633:1: error: the frame size of 1144 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
>
> Normally, gcc optimizes the out, but with CONFIG_CC_OPTIMIZE_FOR_DEBUGGING,
> it does not. Splitting the two stack allocations into separate functions
> means that they will use the same memory again. In normal configurations
> (optimizing for size or performance), those should get inlined and we get
> the same behavior as before.

Thanks for addressing this, applied!

Thanks,
//richard


\
 
 \ /
  Last update: 2018-11-02 21:30    [W:0.031 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site