lkml.org 
[lkml]   [2018]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset
On Wed, Nov 28, 2018 at 05:55:48PM -0800, Grant Grundler wrote:
> On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee <RyanS.Lee@maximintegrated.com> wrote:

> > >Not seeing a changelog here like I asked for :(

> > Actually I added changelog as below. Do you mean this is not sufficient?

> The text is probably sufficient but not in a format that Mark can
> directly apply.
> Please take a quick look at Documentation/process/submitting-patches.rst.

> Mark wants the "commit message" to be before the '---' line. So move
> the "Changes:" text up to become the commit message and drop the
> "Changes" line. That should explain why this commit is needed and
> include the S-o-B line.

Right. If you compare what's in git and what you're sending with other
commits and mails and make sure everything looks similar you're probably
on the right track.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-11-29 12:26    [W:0.098 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site