lkml.org 
[lkml]   [2018]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 65/68] team: no need to do team_notify_peers or team_mcast_rejoin when disabling port
    Date
    From: Hangbin Liu <liuhangbin@gmail.com>

    [ Upstream commit 5ed9dc99107144f83b6c1bb52a69b58875baf540 ]

    team_notify_peers() will send ARP and NA to notify peers. team_mcast_rejoin()
    will send multicast join group message to notify peers. We should do this when
    enabling/changed to a new port. But it doesn't make sense to do it when a port
    is disabled.

    On the other hand, when we set mcast_rejoin_count to 2, and do a failover,
    team_port_disable() will increase mcast_rejoin.count_pending to 2 and then
    team_port_enable() will increase mcast_rejoin.count_pending to 4. We will send
    4 mcast rejoin messages at latest, which will make user confused. The same
    with notify_peers.count.

    Fix it by deleting team_notify_peers() and team_mcast_rejoin() in
    team_port_disable().

    Reported-by: Liang Li <liali@redhat.com>
    Fixes: fc423ff00df3a ("team: add peer notification")
    Fixes: 492b200efdd20 ("team: add support for sending multicast rejoins")
    Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/team/team.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
    index d887016e54b6..4b6572f0188a 100644
    --- a/drivers/net/team/team.c
    +++ b/drivers/net/team/team.c
    @@ -985,8 +985,6 @@ static void team_port_disable(struct team *team,
    team->en_port_count--;
    team_queue_override_port_del(team, port);
    team_adjust_ops(team);
    - team_notify_peers(team);
    - team_mcast_rejoin(team);
    team_lower_state_changed(port);
    }

    --
    2.17.1
    \
     
     \ /
      Last update: 2018-11-29 07:11    [W:4.152 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site