lkml.org 
[lkml]   [2018]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111_suspend
On Wed, Nov 28, 2018 at 09:52:41PM -0800, David Miller wrote:
> From: Nathan Chancellor <natechancellor@gmail.com>
> Date: Wed, 28 Nov 2018 22:18:09 -0700
>
> > Clang warns:
> >
> > drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
> > initialization of subobject [-Wmissing-braces]
> > struct aqc111_wol_cfg wol_cfg = { 0 };
> > ^
> > {}
> > 1 warning generated.
> >
> > Add another set of braces to initialize the char subobjects as well.
> >
> > Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>
> This will in turn make some versions of gcc warn.
>
> Please just memset() this object, thanks.

I thought this was the form that all compilers seemed to agree on but
sure, I will send a v2.

Thanks for the quick response,
Nathan

\
 
 \ /
  Last update: 2018-11-29 06:55    [W:0.069 / U:1.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site