Messages in this thread | | | Date | Wed, 28 Nov 2018 23:05:49 +0100 | From | Christian Brauner <> | Subject | Re: [PATCH v1 2/2] signal: add procfd_signal() syscall |
| |
On Wed, Nov 28, 2018 at 11:45:34AM -1000, Joey Pabalinas wrote: > On Mon, Nov 19, 2018 at 11:32:39AM +0100, Christian Brauner wrote: > > + if (info) { > > + ret = __copy_siginfo_from_user(sig, &kinfo, info); > > + if (unlikely(ret)) > > + goto err; >
I think you're misreading here. It jumps to:
err: fdput(f); return ret;
and does propagate the error. This is also an old iteration of the patch.
Christian
> What's the reason you don't propagate up the errors from __copy_siginfo_from_user()? > Granted, I admit that -E2BIG is kind of weird to return, but -EFAULT seems like a > fairly sane error. > > Or is there some reason it's more useful to just return -EINVAL for all of the > failure cases here? > > -- > Cheers, > Joey Pabalinas
| |