lkml.org 
[lkml]   [2018]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 65/83] Input: xpad - constify usb_device_id
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 94aef061c796d3d47f1a2eed41e651ffaaade402 ]

    usb_device_id are not supposed to change at runtime. All functions
    working with usb_device_id provided by <linux/usb.h> work with
    const usb_device_id. So mark the non-const structs as const.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/input/joystick/xpad.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
    index 298a6ba51411..2578a7677040 100644
    --- a/drivers/input/joystick/xpad.c
    +++ b/drivers/input/joystick/xpad.c
    @@ -408,7 +408,7 @@ static const signed short xpad_abs_triggers[] = {
    #define XPAD_XBOXONE_VENDOR(vend) \
    { XPAD_XBOXONE_VENDOR_PROTOCOL(vend, 208) }

    -static struct usb_device_id xpad_table[] = {
    +static const struct usb_device_id xpad_table[] = {
    { USB_INTERFACE_INFO('X', 'B', 0) }, /* X-Box USB-IF not approved class */
    XPAD_XBOX360_VENDOR(0x044f), /* Thrustmaster X-Box 360 controllers */
    XPAD_XBOX360_VENDOR(0x045e), /* Microsoft X-Box 360 controllers */
    --
    2.17.1


    \
     
     \ /
      Last update: 2018-11-29 16:05    [W:4.061 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site